[llvm-commits] [llvm] r115391 - in /llvm/trunk: CMakeLists.txt lib/Target/MSP430/InstPrinter/CMakeLists.txt

[Jim Grosbach]

On Oct 1, 2010, at 6:32 PM, Óscar Fuentes wrote:

> [Re-sending from my registered e-mail address. Sorry for the duplicate.]
> 
> Francois Pichet <pichet2000 at gmail.com> writes:
> 
>> except there is a missing endif there.
> 
> Yep, I was going to commit a fix for that and another issues (missing
> source files in lib/target/MSP430/CMakeLists.txt, need for an explicit
> dependency of LLVMMS430CodeGen on LLVMMS430AsmPrinter) when it collided
> with the commits of Nick Lewycky reverting the changes.

Ditto. I installed CMake locally to test it out and it was working here, anyway. Waiting to hear back from Nick to see what else may be going awry before re-committing.

> 
> Jim: breaking the cmake build while attempting to reflect your changes
> to the surce code on it is no big problem. If you do nothing to the
> cmake build, it will break too, and with your changes at least we get a
> hint about what changed.

OK. Thank you for being so understanding about it! :)

-Jim