[llvm-commits] [llvm] r115323 - in /llvm/trunk: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp test/DebugInfo/2010-10-01-crash.ll

[Chris Lattner]

On Oct 1, 2010, at 12:00 PM, Devang Patel wrote:

> Author: dpatel
> Date: Fri Oct  1 14:00:44 2010
> New Revision: 115323
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=115323&view=rev
> Log:
> Fix code gen crash reported in PR 8235. We still lose debug info for the unused argument here. This is a known limitation recorded debuginfo-tests/trunk/dbg-declare2.ll function 'f6' test case.

Thanks for fixing the crash Devang.  How hard is it to get the FI# here?  It would be "really great" to be able to get debug info for these.  Losing it at -O0 seems bad.

-Chris

> 
> 
> Added:
>    llvm/trunk/test/DebugInfo/2010-10-01-crash.ll
> Modified:
>    llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
> 
> Modified: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp?rev=115323&r1=115322&r2=115323&view=diff
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp (original)
> +++ llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp Fri Oct  1 14:00:44 2010
> @@ -3955,6 +3955,9 @@
>     const TargetRegisterInfo *TRI = DAG.getTarget().getRegisterInfo();
>     Reg = TRI->getFrameRegister(MF);
>     Offset = FuncInfo.getByValArgumentFrameIndex(Arg);
> +    // If byval argument ofset is not recorded then ignore this.
> +    if (!Offset)
> +      Reg = 0;
>   }
> 
>   if (N.getNode() && N.getOpcode() == ISD::CopyFromReg) {
> 
> Added: llvm/trunk/test/DebugInfo/2010-10-01-crash.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/2010-10-01-crash.ll?rev=115323&view=auto
> ==============================================================================
> --- llvm/trunk/test/DebugInfo/2010-10-01-crash.ll (added)
> +++ llvm/trunk/test/DebugInfo/2010-10-01-crash.ll Fri Oct  1 14:00:44 2010
> @@ -0,0 +1,21 @@
> +; RUN: llc -O0 %s -o /dev/null
> +; PR 8235
> +
> +define void @CGRectStandardize(i32* sret %agg.result, i32* byval %rect) nounwind ssp {
> +entry:
> +  call void @llvm.dbg.declare(metadata !{i32* %rect}, metadata !23), !dbg !24
> +  ret void
> +}
> +
> +declare void @llvm.dbg.declare(metadata, metadata) nounwind readnone
> +
> +declare void @llvm.memcpy.p0i8.p0i8.i32(i8* nocapture, i8* nocapture, i32, i32, i1) nounwind
> +
> +
> +!0 = metadata !{i32 589870, i32 0, metadata !1, metadata !"CGRectStandardize", metadata !"CGRectStandardize", metadata !"CGRectStandardize", metadata !1, i32 54, null, i1 false, i1 true, i32 0, i32 0, null, i32 0, i1 false, void (i32*, i32*)* @CGRectStandardize} ; [ DW_TAG_subprogram ]
> +!1 = metadata !{i32 589865, metadata !"GSFusedSilica.m", metadata !"/Volumes/Data/Users/sabre/Desktop", metadata !2}
> +!2 = metadata !{i32 589841, i32 0, i32 16, metadata !"GSFusedSilica.m", metadata !"/Volumes/Data/Users/sabre/Desktop", metadata !"clang version 2.9 (trunk 115292)", i1 true, i1 false, metadata !"", i32 1} ; [ DW_TAG_compile_unit ]
> +!5 = metadata !{i32 589846, metadata !1, metadata !"CGRect", metadata !1, i32 49, i64 0, i64 0, i64 0, i32 0, null}
> +!23 = metadata !{i32 590081, metadata !0, metadata !"rect", metadata !1, i32 53, metadata !5, i32 0} ; [ DW_TAG_arg_variable ]
> +!24 = metadata !{i32 53, i32 33, metadata !0, null}
> +
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits