[llvm-commits] [llvm] r114856 - in /llvm/trunk/lib/Target/ARM: ARMELFWriterInfo.cpp ARMELFWriterInfo.h ARMSubtarget.h ARMTargetMachine.cpp ARMTargetMachine.h CMakeLists.txt

[Jim Grosbach]

On Oct 1, 2010, at 12:04 PM, Rafael Espíndola wrote:

>> The target data string still needs to be passed down from the subclasses, though, not handled directly by the base target machine class. Likewise the InstrInfo object creation. Moving that stuff to the base class is counter to having the subclasses. Some of the members (that don't need subtarget information beyond what's in the DataLayout, like TSInfo and TLInfo) can still be moved to the base class just fine. The InstrInfo would need to stay in the subclasses since that's where that data is. This would, I think, give us effectively the best of both.
> 
> So, what do you suggest as the way forward? I would propose committing
> factor.patch and I will try to work a bit more on making DataLayout a
> member of LLVMTargetMachine (likely next week).

That sounds like a good plan to me.  Please commit. Thanks!

-Jim