[llvm-commits] [llvm] r115141 - in /llvm/trunk: include/llvm/MC/MCSectionELF.h lib/MC/MCContext.cpp lib/MC/MCSectionELF.cpp test/MC/ELF/entsize.ll

[Jan Wen Voung]

Author: jvoung
Date: Thu Sep 30 00:59:22 2010
New Revision: 115141

URL: http://llvm.org/viewvc/llvm-project?rev=115141&view=rev
Log:
Move logic of determining ELF entsize from the .s printer to initialization
time. That way, the EntrySize field is initialized for other code paths, 
namely, the .ll -> .o code path.


Added:
    llvm/trunk/test/MC/ELF/entsize.ll
Modified:
    llvm/trunk/include/llvm/MC/MCSectionELF.h
    llvm/trunk/lib/MC/MCContext.cpp
    llvm/trunk/lib/MC/MCSectionELF.cpp

Modified: llvm/trunk/include/llvm/MC/MCSectionELF.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/MC/MCSectionELF.h?rev=115141&r1=115140&r2=115141&view=diff
==============================================================================
--- llvm/trunk/include/llvm/MC/MCSectionELF.h (original)
+++ llvm/trunk/include/llvm/MC/MCSectionELF.h Thu Sep 30 00:59:22 2010
@@ -189,6 +189,10 @@
     return S->getVariant() == SV_ELF;
   }
   static bool classof(const MCSectionELF *) { return true; }
+
+  // Return the entry size for sections with fixed-width data.
+  static unsigned DetermineEntrySize(SectionKind Kind);
+
 };
 
 } // end namespace llvm

Modified: llvm/trunk/lib/MC/MCContext.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCContext.cpp?rev=115141&r1=115140&r2=115141&view=diff
==============================================================================
--- llvm/trunk/lib/MC/MCContext.cpp (original)
+++ llvm/trunk/lib/MC/MCContext.cpp Thu Sep 30 00:59:22 2010
@@ -160,6 +160,10 @@
   StringMapEntry<const MCSectionELF*> &Entry = Map.GetOrCreateValue(Section);
   if (Entry.getValue()) return Entry.getValue();
   
+  // Possibly refine the entry size first.
+  if (!EntrySize) {
+    EntrySize = MCSectionELF::DetermineEntrySize(Kind);
+  }
   MCSectionELF *Result = new (*this) MCSectionELF(Entry.getKey(), Type, Flags,
                                                   Kind, IsExplicit, EntrySize);
   Entry.setValue(Result);

Modified: llvm/trunk/lib/MC/MCSectionELF.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCSectionELF.cpp?rev=115141&r1=115140&r2=115141&view=diff
==============================================================================
--- llvm/trunk/lib/MC/MCSectionELF.cpp (original)
+++ llvm/trunk/lib/MC/MCSectionELF.cpp Thu Sep 30 00:59:22 2010
@@ -104,17 +104,8 @@
     else if (Type == MCSectionELF::SHT_PROGBITS)
       OS << "progbits";
   
-    if (getKind().isMergeable1ByteCString()) {
-      OS << ",1";
-    } else if (getKind().isMergeable2ByteCString()) {
-      OS << ",2";
-    } else if (getKind().isMergeable4ByteCString() || 
-               getKind().isMergeableConst4()) {
-      OS << ",4";
-    } else if (getKind().isMergeableConst8()) {
-      OS << ",8";
-    } else if (getKind().isMergeableConst16()) {
-      OS << ",16";
+    if (EntrySize) {
+      OS << "," << EntrySize;
     }
   }
   
@@ -132,4 +123,12 @@
   return false;
 }
 
-
+unsigned MCSectionELF::DetermineEntrySize(SectionKind Kind) {
+  if (Kind.isMergeable1ByteCString()) return 1;
+  if (Kind.isMergeable2ByteCString()) return 2;
+  if (Kind.isMergeable4ByteCString()) return 4;
+  if (Kind.isMergeableConst4())       return 4;
+  if (Kind.isMergeableConst8())       return 8;
+  if (Kind.isMergeableConst16())      return 16;
+  return 0;
+}

Added: llvm/trunk/test/MC/ELF/entsize.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/ELF/entsize.ll?rev=115141&view=auto
==============================================================================
--- llvm/trunk/test/MC/ELF/entsize.ll (added)
+++ llvm/trunk/test/MC/ELF/entsize.ll Thu Sep 30 00:59:22 2010
@@ -0,0 +1,44 @@
+; RUN: llc -filetype=obj -mtriple x86_64-pc-linux-gnu %s -o - | elf-dump | FileCheck -check-prefix=64 %s
+
+; Test that constant mergeable strings have sh_entsize set.
+
+ at .str1 = private constant [6 x i8] c"tring\00"
+ at .str2 = private constant [7 x i8] c"String\00"
+ at .c8a = private constant [1 x i64] [i64 42]
+ at .c8b = private constant [1 x i64] [i64 42]
+
+define i32 @main() nounwind {
+  %1 = call i32 @puts(i8* getelementptr inbounds ([6 x i8]* @.str1, i32 0, i32 0))
+  %2 = call i32 @puts(i8* getelementptr inbounds ([7 x i8]* @.str2, i32 0, i32 0))
+  call void @foo(i64* getelementptr inbounds ([1 x i64]* @.c8a, i32 0, i32 0))
+  call void @foo(i64* getelementptr inbounds ([1 x i64]* @.c8b, i32 0, i32 0))
+  ret i32 0
+}
+
+declare i32 @puts(i8* nocapture) nounwind
+declare void @foo(i64* nocapture) nounwind
+
+;;;;;
+
+; 64: (('sh_name', 7) # '.rodata.str1.1'
+; 64-NEXT:   ('sh_type', 1)
+; 64-NEXT:   ('sh_flags', 50)
+; 64-NEXT:   ('sh_addr',
+; 64-NEXT:   ('sh_offset',
+; 64-NEXT:   ('sh_size', 13)
+; 64-NEXT:   ('sh_link',
+; 64-NEXT:   ('sh_info',
+; 64-NEXT:   ('sh_addralign', 1)
+; 64-NEXT:   ('sh_entsize', 1)
+
+; 64: (('sh_name', 22) # '.rodata.cst8'
+; 64-NEXT:   ('sh_type', 1)
+; 64-NEXT:   ('sh_flags', 18)
+; 64-NEXT:   ('sh_addr',
+; 64-NEXT:   ('sh_offset',
+; 64-NEXT:   ('sh_size', 16)
+; 64-NEXT:   ('sh_link',
+; 64-NEXT:   ('sh_info',
+; 64-NEXT:   ('sh_addralign', 8)
+; 64-NEXT:   ('sh_entsize', 8)
+