[llvm-commits] [PATCH, PING] Thumb2 peephole opt

[Bill Wendling]

On Sep 28, 2010, at 5:22 AM, Gabor Greif wrote:

> Hi all,
> 
> attached you can find a resend of my thumb2 peephole opt.
> It eliminates a 'tst' instruction after an 'and' instruction when
> the immediate mask is the same.
> 
> Feedback welcome, please tell whether ok to commit.
> 
Szia Gabor,

This looks fine. A couple of comments:

- In the tests, it's probably not necessary to check for the exact name of the branch label. If that changes in the future, it will require the tests to be updated.

- Please comment the "isSuitableForMask" function. :)

Thanks!
-bw