[llvm-commits] [llvm] r114850 - /llvm/trunk/tools/lto/LTOModule.cpp

[Bill Wendling]

On Sep 28, 2010, at 2:14 AM, Duncan Sands wrote:

> Hi Bill,
> 
>>    // set definition part
>> -  if (def->hasWeakLinkage() || def->hasLinkOnceLinkage()) {
>> +  if (def->hasWeakLinkage() || def->hasLinkOnceLinkage() ||
>> +      def->hasLinkerPrivateWeakLinkage() ||
>> +      def->hasLinkerPrivateWeakDefAutoLinkage()) {
>>      attr |= LTO_SYMBOL_DEFINITION_WEAK;
> 
> maybe this should be using isWeakForLinker (from GlobalValue.h)?  It doesn't
> have exactly the same list of linkage types, but it's suspiciously close.
> 
I thought about that, but that predicate includes the "common" linkage, which is handled directly below. It also contains the "linker_private_weak_def_auto" linkage which is also handled separately.

It may be a good clean up to do at some point. :)

-bw