[llvm-commits] [llvm] r114958 - in /llvm/trunk: lib/MC/ELFObjectWriter.cpp test/MC/ELF/undef.s

[Rafael Espindola]

Author: rafael
Date: Tue Sep 28 11:19:11 2010
New Revision: 114958

URL: http://llvm.org/viewvc/llvm-project?rev=114958&view=rev
Log:
On elf, undefined symbols can start with .L.

Added:
    llvm/trunk/test/MC/ELF/undef.s
Modified:
    llvm/trunk/lib/MC/ELFObjectWriter.cpp

Modified: llvm/trunk/lib/MC/ELFObjectWriter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/ELFObjectWriter.cpp?rev=114958&r1=114957&r2=114958&view=diff
==============================================================================
--- llvm/trunk/lib/MC/ELFObjectWriter.cpp (original)
+++ llvm/trunk/lib/MC/ELFObjectWriter.cpp Tue Sep 28 11:19:11 2010
@@ -689,12 +689,15 @@
     const MCSymbol &Symbol = it->getSymbol();
 
     // Ignore non-linker visible symbols.
-    if (!Asm.isSymbolLinkerVisible(Symbol))
+    if (!Asm.isSymbolLinkerVisible(Symbol) && !Symbol.isUndefined())
       continue;
 
     if (!it->isExternal() && !Symbol.isUndefined())
       continue;
 
+    if (Symbol.isVariable())
+      continue;
+
     uint64_t &Entry = StringIndexMap[Symbol.getName()];
     if (!Entry) {
       Entry = StringTable.size();

Added: llvm/trunk/test/MC/ELF/undef.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/ELF/undef.s?rev=114958&view=auto
==============================================================================
--- llvm/trunk/test/MC/ELF/undef.s (added)
+++ llvm/trunk/test/MC/ELF/undef.s Tue Sep 28 11:19:11 2010
@@ -0,0 +1,15 @@
+// RUN: llvm-mc -filetype=obj -triple x86_64-pc-linux-gnu %s -o - | elf-dump  | FileCheck %s
+
+// Test that there is an undefined reference to .Lset0, but not .Lset1
+
+        .long	.Lset0
+foo:
+bar:
+.Lset1 = foo - bar
+        .long	.Lset1
+
+// CHECK: ('_symbols', [
+// CHECK-NOT: Lset1
+// CHECK:  (('st_name', 9) # '.Lset0'
+// CHECK-NOT: Lset1
+// CHECK: (('sh_name', 36) # '.strtab'