[llvm-commits] Initial cut of ARM MC ELF emitter (PATCH)

[Rafael Espindola]

On 27 September 2010 13:31, Jim Grosbach <grosbach at apple.com> wrote:
> It's much improved, but theres still one thing from my original comments that needs fixing.
>
> The most recent patch still contains the bits moving the TargetData information into the base ARMBaseTargetMachine class from the ARMTargetMachine and ThumbTargetMachine classes. That's not appropriate. That sort of information is what the subclasses are there for. Please undo those changes.

I noticed that too, but X86 does the same thing. Would you like me to
move TargetData to the subclasses of X86TargetMachine? I agree that
the current situation is a bit silly since getTargetData is virtual
and DataLayout is set only in X86TargetMachine.

> -Jim

Cheers,
-- 
Rafael Ávila de Espíndola