[llvm-commits] [llvm] r114667 - in /llvm/trunk: lib/MC/ELFObjectWriter.cpp test/MC/ELF/local-reloc.s

[Rafael Espindola]

Author: rafael
Date: Thu Sep 23 12:25:18 2010
New Revision: 114667

URL: http://llvm.org/viewvc/llvm-project?rev=114667&view=rev
Log:
Represent relocations against local symbols as relocations against the section
they are in. Both ways should be equivalent, but gas produces relocations
against the section.

Roman wrote the patch, I added the test.

Added:
    llvm/trunk/test/MC/ELF/local-reloc.s
Modified:
    llvm/trunk/lib/MC/ELFObjectWriter.cpp

Modified: llvm/trunk/lib/MC/ELFObjectWriter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/ELFObjectWriter.cpp?rev=114667&r1=114666&r2=114667&view=diff
==============================================================================
--- llvm/trunk/lib/MC/ELFObjectWriter.cpp (original)
+++ llvm/trunk/lib/MC/ELFObjectWriter.cpp Thu Sep 23 12:25:18 2010
@@ -502,7 +502,7 @@
     }
 
     if (Base) {
-      if (F && (!Symbol->isInSection() || SD.isCommon()) && !SD.isExternal()) {
+      if (F && !SD.isExternal()) {
         Index = F->getParent()->getOrdinal() + LocalSymbolData.size() + 1;
         Value += Layout.getSymbolAddress(&SD);
       } else

Added: llvm/trunk/test/MC/ELF/local-reloc.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/ELF/local-reloc.s?rev=114667&view=auto
==============================================================================
--- llvm/trunk/test/MC/ELF/local-reloc.s (added)
+++ llvm/trunk/test/MC/ELF/local-reloc.s Thu Sep 23 12:25:18 2010
@@ -0,0 +1,32 @@
+// RUN: llvm-mc -filetype=obj -triple x86_64-pc-linux-gnu %s -o - | elf-dump  --dump-section-data | FileCheck  %s
+
+// Test that relocations with local symbols are represented as relocations
+// with the section. They should be equivalent, but gas behaves like this.
+
+	movl	foo, %r14d
+foo:
+
+// Section number 1 is .text
+// CHECK:        # Section 1
+// CHECK-next:  (('sh_name', 1) # '.text'
+
+
+// Relocation refers to symbol number 2
+// CHECK:      ('_relocations', [
+// CHECK-NEXT:  # Relocation 0
+// CHECK-NEXT:   (('r_offset',
+// CHECK-NEXT:    ('r_sym', 2)
+// CHECK-NEXT:    ('r_type',
+// CHECK-NEXT:    ('r_addend',
+// CHECK-NEXT:   ),
+// CHECK-NEXT:  ])
+
+// Symbol number 2 is section number 1
+// CHECK:    # Symbol 2
+// CHECK-NEXT:    (('st_name', 0) # ''
+// CHECK-NEXT:     ('st_bind', 0)
+// CHECK-NEXT:     ('st_type', 3)
+// CHECK-NEXT:     ('st_other', 0)
+// CHECK-NEXT:     ('st_shndx', 1)
+// CHECK-NEXT:     ('st_value', 0)
+// CHECK-NEXT:     ('st_size', 0)