[llvm-commits] [llvm] r114404 - /llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

[Chris Lattner]

On Sep 21, 2010, at 9:56 AM, Owen Anderson wrote:

> 
> On Sep 20, 2010, at 11:02 PM, Chris Lattner wrote:
> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=114404&view=rev
>> Log:
>> update the X86 backend to use the MachinePointerInfo version of one
>> of the getLoad methods.  This fixes at least one bug where an incorrect
>> svoffset is passed in (a potential combiner-aa miscompile).
> 
> FYI, there are two parts to CombinerAA: -combiner-alias-analysis, which does not use SrcValues at all, only Machine-level information, and -combiner-global-alias-analysis, which uses IR-level AA.  I have only been trying to get the former up to snuff, not the latter, which is why these miscompilations weren't detected.

Aha, good to know!

-Chris