[llvm-commits] [llvm] r114148 - in /llvm/trunk: lib/Analysis/ConstantFolding.cpp test/Transforms/InstCombine/fold-calls.ll

Daniel Dunbar daniel at zuster.org
Mon Sep 20 13:20:06 PDT 2010


On Mon, Sep 20, 2010 at 11:42 AM, Eli Friedman <eli.friedman at gmail.com> wrote:
> On Mon, Sep 20, 2010 at 9:38 AM, Daniel Dunbar <daniel at zuster.org> wrote:
>> Hi Dan,
>>
>> This change doesn't seem right to me. It is introducing a host ==
>> target dependency of sorts. Somehow this information should be coming
>> from the Target definitions or information in the IR file, not from
>> the host's fenv() implementation.
>
> What are you talking about?  This change is just to detect errors
> coming out of the host's math functions, and doesn't really have much
> to do with the target's implementation of sin().

Aren't the hosts math functions being used in this case to make
optimization decisions?

 - Daniel

>
> -Eli
>




More information about the llvm-commits mailing list