[llvm-commits] [PATCH] Add exit instruction to PTX backend

[Che-Liang Chiou]

Hi Chris,

Thanks for the comments.  I've put {'s on the previous line and
removed accidentally added tab characters.  I've also checked again
that cmake file was updated.  Thanks for reminding.

I regenerate patch against r114073.  Please take a look.

Regards,
Che-Liang

On Thu, Sep 16, 2010 at 6:54 AM, Chris Lattner <clattner at apple.com> wrote:
>
> On Sep 14, 2010, at 1:59 AM, Che-Liang Chiou wrote:
>
>> Hi,
>>
>> I have created a patch that adds "exit" instruction to PTX backend.
>>
>> SVN revision:
>> 113836
>>
>> TEST:
>> $ cd llvm/test/
>> $ llvm-lit CodeGen/PTX/exit.ll
>> -- Testing: 1 tests, 8 threads --
>> PASS: LLVM :: CodeGen/PTX/exit.ll (1 of 1)
>> Testing Time: 0.01s
>>  Expected Passes    : 1
>
> Looks good to me.  Please make sure to update the cmake file.  Also, please put your {'s on the "previous line" instead of on a new line.
>
> -Chris
>
>>
>> Note:
>> Compiling auto generated cpp file produces warning.  I suspect the it
>> is because of too few instructions in .td file for now.  The warning
>> message should look like this:
>>
>> In file included from PTXAsmPrinter.cpp:50:
>> /usr/local/google/clchiou/llvm/llvm/lib/Target/PTX/AsmPrinter/../PTXGenAsmWriter.inc:
>> In member function
>> ‘void<unnamed>::PTXAsmPrinter::printInstruction(const
>> llvm::MachineInstr*, llvm::raw_ostream&)’:
>> /usr/local/google/clchiou/llvm/llvm/lib/Target/PTX/AsmPrinter/../PTXGenAsmWriter.inc:43:
>> warning: right shift count >= width of type
>>
>> This warning should disappear after more instructions are added.
>>
>> Regards,
>> Che-Liang
>> <r113836-add-exit.patch>_______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: r114073-add-exit.patch
Type: text/x-patch
Size: 31615 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100916/87cdf8a6/attachment.bin>