[llvm-commits] [llvm] r113996 - in /llvm/trunk: include/llvm/MC/MCInst.h lib/Target/ARM/ARMMCInstLower.cpp lib/Target/ARM/AsmPrinter/ARMInstPrinter.cpp

[Jim Grosbach]

On Sep 15, 2010, at 3:34 PM, Chris Lattner wrote:

> 
> On Sep 15, 2010, at 11:47 AM, Jim Grosbach wrote:
> 
>> Author: grosbach
>> Date: Wed Sep 15 13:47:08 2010
>> New Revision: 113996
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=113996&view=rev
>> Log:
>> Add support for floating point immediates to MC instruction printing. ARM
>> VFP instructions use it for loading some constants, so implement that
>> handling.
>> 
>> Not thrilled with adding a member to MCOperand, but not sure there's much of
>> a better option that's not pretty fragile (like putting a double in the
>> union instead and just assuming that's good enough). Suggestions welcome...
> 
> Please just use "double" or, better yet, "int64_t" instead, and have an accessor turn that into an apfloat.  The new kFPImmediate kind is great, we just really want MCOperand to avoid a dtor.

That makes sense. Should be able to get to that this evening. Thanks!

-Jim