[llvm-commits] [llvm] r113996 - in /llvm/trunk: include/llvm/MC/MCInst.h lib/Target/ARM/ARMMCInstLower.cpp lib/Target/ARM/AsmPrinter/ARMInstPrinter.cpp

[Jim Grosbach]

On Sep 15, 2010, at 1:28 PM, Stephen Canon wrote:

> On Sep 15, 2010, at 1:22 PM, Jim Grosbach wrote:
> 
>> I wish I could, but unified syntax requires the immediate be a floating point immediate. Pre-unified syntax it was a binary 8 bit immediate as encoded into the instruction. I wish it hadn't been changed, but...
> 
> Does it forbid a hex-encoded FP immediate? #0x1.ap2, for example?

Yes. :(

x.s:3:garbage following instruction -- `vmov.f32 s0,#0x1.ap2'

For context, note that nothing in this patch is changing how we're printing FP immediates for these instructions. Rather, this is implementing for MC-based printing the same logic that's currently used for the old assembly printer. That's certainly not to say that there isn't room for improvement. :)

-Jim