[llvm-commits] [llvm] r113875 - /llvm/trunk/lib/Target/ARM/AsmPrinter/ARMInstPrinter.cpp

Jakob Stoklund Olesen stoklund at 2pi.dk
Tue Sep 14 16:58:36 PDT 2010


On Sep 14, 2010, at 4:32 PM, Jim Grosbach wrote:
> 
> Yeah. It's definitely ugly all the way around. I'm planning to refactor the way we handle these dregpair operands as part of this whole process with MC inst printing, and hopefully I'll be able to get rid of this ugliness altogether. We shall see. In the meantime, I think I prefer the longer, but more explicit, ugly rather than the short and tricky ugly. Specifically, I'd like to avoid tying your hands with regards to register ordering. As I recall, you've been tossing around ideas that might change that sort of thing(?) That said, I don't feel strongly about it, so if you think the short and tricky version is better, I'll be easy to convince. :)

I was playing with ordering registers topologically to permit a better implementation of TRI.regsOverlap. It didn't really work out to be an improvement, but its probably good to leave the door open for such tinkering.

Let's all not look at SSEDomainFixPass::RegIndex and X86FloatingPoint::getFPReg now ;-)

/jakob





More information about the llvm-commits mailing list