[llvm-commits] [llvm] r113632 - in /llvm/trunk: ./ cmake/modules/ examples/BrainF/ examples/ExceptionDemo/ examples/Fibonacci/ examples/HowToUseJIT/ examples/Kaleidoscope/Chapter3/ examples/Kaleidoscope/Chapter4/ examples/Kaleidoscope/Chapter5/ e

Douglas Gregor dgregor at apple.com
Sat Sep 11 12:54:48 PDT 2010


On Sep 11, 2010, at 12:35 PM, Óscar Fuentes wrote:

> Michael Spencer <bigcheesegs at gmail.com> writes:
> 
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=113632&view=rev
>>>> Log:
>>>> CMake: Get rid of LLVMLibDeps.cmake and export the libraries normally.
>>> 
>>> Who approved this change?
>> 
>> Douglas Gregor.
> 
> As you refused to discuss my concerns and committed the change against
> my opinion, I'll take this as an statement from Doug about him taking
> the responsibility of the CMake build and the irrelevance of my opinion
> as the original author and maintainer, so I'll refrain from further work
> on that area.
> 
> That said, I'm very surprised to see this antisocial behavior on LLVM.


I'm sorry, I completely missed your replies. Michael sent the patch to both llvmdev and llvm-commits, and I was watching llvmdev but not llvm-commits. So, when you "elided" llvmdev in your reply to Michael, I missed that and the subsequent discussion. Seeing no discussion, I approved the patch. My apologies for the misunderstanding! 

I'll reply to you over on llvm-commits about the technical details. If you think the changes should be reverted while we discuss them, we can do that.

	- Doug






More information about the llvm-commits mailing list