[llvm-commits] [llvm] r113618 - in /llvm/trunk: bindings/ocaml/llvm/ include/llvm-c/ include/llvm/ include/llvm/Bitcode/ include/llvm/Support/ lib/AsmParser/ lib/Bitcode/Reader/ lib/Bitcode/Writer/ lib/Target/ lib/Target/CBackend/ lib/Target/CppBackend/ lib/VMCore/

[Chris Lattner]

On Sep 10, 2010, at 1:55 PM, Dale Johannesen wrote:

> Author: johannes
> Date: Fri Sep 10 15:55:01 2010
> New Revision: 113618
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=113618&view=rev
> Log:
> Add X86 MMX type to bitcode and Type.
> (The Ada bindings probably need it too, but all the
> obvious places to change say "do not edit this file".)
> 
Looks good, thanks Dale.

One minor nit, a comment pasto.

> 
> +  /// isPPC_FP128Ty - Return true if this is X86 MMX.
> +  bool isX86_MMXTy() const { return ID == X86_MMXTyID; }

Please add a testcase to test/Assembler to ensure that these are round tripping through the .ll and .bc reader/parser.  Thanks!

-Chris