[llvm-commits] [PATCH][MS][Review request] - Fix index lit tests failing on Windows

[Douglas Gregor]

On Sep 11, 2010, at 10:16 AM, Francois Pichet wrote:

> This patch fixes all the index lit tests failing on Win32.
> 
> lit index tests were failing on windows because GetPreamblePCHPath was
> returning a empty string.
> Returning a empty string because when python spawn c-index-test.exe
> neither "TMPDIR", "TEMP" or "TMP" are defined as environment
> variables.

Thanks for tracking this down! It's a very weird error indeed.

> Then GetPreamblePCHPath  returning "" created a complicated chain of
> events leading to a crash. Probably the code should be more robust.


We should fix GetPreamblePCHPatch, so that it doesn't fail in this case, and also fix its caller, so that it can handle such a failure gracefully. I'll take a shot at it. However, I don't think you should commit this change to lit, because none of the tests should require it.

	- Doug