[llvm-commits] [poolalloc] r113507 - /poolalloc/trunk/lib/DSA/Local.cpp

Will Dietz wdietz2 at illinois.edu
Thu Sep 9 10:45:59 PDT 2010


Author: wdietz2
Date: Thu Sep  9 12:45:59 2010
New Revision: 113507

URL: http://llvm.org/viewvc/llvm-project?rev=113507&view=rev
Log:
Reworded comment.
No functionality changes.

Modified:
    poolalloc/trunk/lib/DSA/Local.cpp

Modified: poolalloc/trunk/lib/DSA/Local.cpp
URL: http://llvm.org/viewvc/llvm-project/poolalloc/trunk/lib/DSA/Local.cpp?rev=113507&r1=113506&r2=113507&view=diff
==============================================================================
--- poolalloc/trunk/lib/DSA/Local.cpp (original)
+++ poolalloc/trunk/lib/DSA/Local.cpp Thu Sep  9 12:45:59 2010
@@ -903,13 +903,13 @@
     }
   }
 
-  //NOTE: This code is identical to 'DSGraph::getDSCallSiteForCallSite',
-  //the reason it's duplicated is so because this calls getValueDest, 
-  //instead of getNodeForValue. Possibly because a DS node may not exist
-  //at this time, in which case getNodeForValue, creates the node, unlike
-  // getNodeForValue.
+  // NOTE: This code is identical to 'DSGraph::getDSCallSiteForCallSite',
+  // the reason it's duplicated is because this calls getValueDest instead
+  // of getNodeForValue to get the DSNodes for the arguments.  Since we're in
+  // local it's possible that we need to create a DSNode for the argument, as
+  // opposed to getNodeForValue which simply retrieves the existing node.
   
-  //FIXME: refactor so we don't have this duplication. 
+  // FIXME: refactor so we don't have this duplication. 
 
   //Get the FunctionType for the called function
   const FunctionType *CalleeFuncType = DSCallSite::FunctionTypeOfCallSite(CS);





More information about the llvm-commits mailing list