[llvm-commits] [PATCH] InstCombine: Generalized patch for (icmp eq (A&B), C) & (icmp eq (A&D), E), again

Dirk Steinke steinke-dirk at web.de
Wed Sep 8 12:19:54 PDT 2010


Hi,

a couple weeks ago I provided (basically) the same patch to InstCombine.
According to Owen:
 > Dirk,
 >
 > Your updated testcase (bit-checks.ll) doesn't pass for me after
 > applying your patch.
 >
 > --Owen

Meanwhile I've setup a Linux box (VM) for LLVM, applied the patch,
ran 'make' and 'make check', and there were only expected failures.
So it wasn't my fault, and I'm all happy. :-)
Please review again and apply.

The attached version handles more testcases, has a bug fixed (which
was detected by one of the new tests), has an early out if the icmp's
do not compare the same integer type, and does no longer (unvoluntarily)
handle integer vectors. (Integer vectors might work, but I didn't think
this through yet.)

Bye
Dirk


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: foldmaskedicmp3.diff
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100908/ae62ab51/attachment.ksh>


More information about the llvm-commits mailing list