[llvm-commits] [llvm] r113237 - in /llvm/trunk/test/CodeGen/X86: dbg-declare-fastisel.ll dbg-declare-hybrid.ll dbg-declare-isel.ll

[Chris Lattner]

On Sep 7, 2010, at 2:52 PM, Devang Patel wrote:

>>>>> URL: http://llvm.org/viewvc/llvm-project?rev=113237&view=rev
>>>>> Log:
>>>>> Fix command line used to link these test cases.
>>>> 
>>>> Are these tests going to work on non-native hosts (e.g. a mips linux box)?  These seem like something that should be in a different test suite.
>>> 
>>> This test should in a suite that is required to be run before every  codegen check-in.
>>> 
>>> I update these tests so that they are not forcing a target. This should work on all x86 platforms unless there is a platform specific bug.
>> 
>> lib/CodeGen/X86 needs to run on any host.  You are forcing the programs to build with the X86 code generator, then run.  THis won't work unless the host is x86.
> 
> Is there any way to skip the test in this case ? What else do you suggest ?

There is some XHOST thing I think, but it's better to have a dedicated place for this.  It's not like these are the only debug info tests we should have.  Why not put them in the gdb testsuite or something that already has a harness?

-Chris