[llvm-commits] [llvm] r112976 - /llvm/trunk/Makefile.rules

[Dan Gohman]

On Sep 4, 2010, at 6:57 PM, NAKAMURA Takumi wrote:

> Dan,
> 
> A bad news, it broke mingw's enable_shared.
> 
> HAVE_LINK_VERSION_SCRIPT is set on mingw by autoconf,
> regadless of functionality of it.
> 
> Also RPATH, RDYNAMIC are set.
> 
> They are accepted but ignored by GNU ld win32.

That's surprising, and sounds like a bug.

> 
> To reorder "if (HAVE_LINK_VERSION_SCRIPT) clause and if (cyginw ||
> mingw) clause",
> it would be resolved.

This sounds fine to me, provided it's accompanied by a comment.

Or, you could change the autoconf code to avoid setting
HAVE_LINK_VERSION_SCRIPT if the linker doesn't *really* support it.

Dan