[llvm-commits] [llvm] r108888 - in /llvm/trunk: include/llvm/PassRegistry.h lib/VMCore/PassRegistry.cpp

Chris Lattner clattner at apple.com
Sun Sep 5 15:40:22 PDT 2010


On Jul 20, 2010, at 12:23 PM, Owen Anderson wrote:
> URL: http://llvm.org/viewvc/llvm-project?rev=108888&view=rev
> Log:
> I just fail with SVN today.


That may be, but this is a useless commit message.  even if you fail or reapply a previous patch, your commit message should be descriptive.

> +++ llvm/trunk/lib/VMCore/PassRegistry.cpp Tue Jul 20 14:23:55 2010
> @@ -0,0 +1,72 @@
> +//===- PassRegistry.cpp - Pass Registration Implementation ----------------===//
> +//
> +//                     The LLVM Compiler Infrastructure
> +//
> +// This file is distributed under the University of Illinois Open Source
> +// License. See LICENSE.TXT for details.
> +//
> +//===----------------------------------------------------------------------===//
> +//
> +// This file implements the PassRegistry, with which passes are registered on
> +// initialization, and supports the PassManager in dependency resolution.
> +//
> +//===----------------------------------------------------------------------===//
> +
> +#include "llvm/PassRegistry.h"
> +#include "llvm/System/Mutex.h"

Mutex.h is a redundant #include, but beyond that, none of these should be locked anyway.

-Chris





More information about the llvm-commits mailing list