[llvm-commits] [llvm] r113059 - /llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

Bruno Cardoso Lopes bruno.cardoso at gmail.com
Fri Sep 3 19:58:56 PDT 2010


Author: bruno
Date: Fri Sep  3 21:58:56 2010
New Revision: 113059

URL: http://llvm.org/viewvc/llvm-project?rev=113059&view=rev
Log:
Remove the last bit of isShuffleMaskLegal checks and improve the comment regarding mmx shuffles

Modified:
    llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=113059&r1=113058&r2=113059&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Fri Sep  3 21:58:56 2010
@@ -5472,14 +5472,12 @@
                                 X86::getShufflePALIGNRImmediate(SVOp),
                                 DAG);
 
-  // MMX shuffles not already handled must be expanded.
+  // Only a few shuffle masks are handled for 64-bit vectors (MMX), and
+  // 64-bit vectors which made to this point can't be handled, they are
+  // expanded.
   if (VT.getSizeInBits() == 64)
     return SDValue();
 
-  // FIXME: pshufb, blends, shifts.
-  if (VT.getVectorNumElements() == 2)
-    return Op;
-
   if (ShuffleVectorSDNode::isSplatMask(&M[0], VT) &&
       SVOp->getSplatIndex() == 0 && V2IsUndef) {
     if (VT == MVT::v2f64)





More information about the llvm-commits mailing list