[llvm-commits] [PATCH] test/CodeGen/X86 patches for win32

NAKAMURA Takumi geek4civic at gmail.com
Thu Sep 2 06:04:36 PDT 2010


Anton,

Thank you comments. I understand,
"Tests should be funcionality test, not environment test."

> test/CodeGen/X86/2009-03-13-PHIElimBug.ll
> test/CodeGen/X86/2009-03-16-PHIElimInLPad.ll
> test/CodeGen/X86/dyn-stackalloc.ll

I will commit 3 of them tonight, with -mtriple=(i686|x86_64)-linux

> Also, it's not obvious why you need to change
> test/CodeGen/X86/twoaddr-coalesce.ll

I thought this test would not require to be @main.

In fact, (a part) difference among @foo(-) and @main(+) is below on
cygwin and mingw;

-_foo:
+_main:
 # BB#0:
+       pushl   %ebp
+       movl    %esp, %ebp
        pushl   %ebx
-       subl    $8, %esp
+       subl    $12, %esp
+       call    ___main

With -mtriple=i686-linux, they are almost same.

ps. Thanks to Duncan, to give me several advices about triplet on the irc today.


Sleepy Thursday...Takumi



More information about the llvm-commits mailing list