[llvm-commits] [llvm] r112420 - /llvm/trunk/include/llvm/Support/StandardPasses.h

[Chris Lattner]

On Aug 30, 2010, at 12:23 AM, Duncan Sands wrote:

> Hi Chris,
> 
>>>> I never got around to changing it to use the SSA updator.  That
>>>> said, I could easily change it to not promote the alloca to a
>>>> register.  Since it's only used if an exception is raised, that
>>>> wouldn't be a big loss.
>> 
>> I took care of this.  I need to refactor some code, but it's done.
> 
> thanks for doing this.  I would have done it somewhat differently;
> since you reverted your commit I will give my alternative approach
> a go (hopefully I will finish this on Wednesday).

Sounds great!  I went with the approach that didn't require me to understand the code, doing something smarter than a "general alloca promotion" would be much better.

I reverted it because it caused some failures on self host and the testsuite, but they are linux specific, so I can't repro :-(

-Chris