[llvm-commits] [llvm] r112029 - /llvm/trunk/tools/llvm-link/CMakeLists.txt

[Eric Christopher]

On Aug 25, 2010, at 7:44 PM, Óscar Fuentes wrote:

> Eric Christopher <echristo-2kanFRK1NckAvxtiuMwx3w at public.gmane.org>
> writes:
> 
>> Apparently this is needed for llvm-link to link.
>> 
>> --- llvm/trunk/tools/llvm-link/CMakeLists.txt (original)
>> +++ llvm/trunk/tools/llvm-link/CMakeLists.txt Wed Aug 25 01:45:22 2010
>> @@ -1,4 +1,4 @@
>> -set(LLVM_LINK_COMPONENTS linker bitreader bitwriter asmparser)
>> +set(LLVM_LINK_COMPONENTS linker bitreader bitwriter asmparser transformutils)
> 
> I've reverted this change and committed updated library dependencies.
> 
> Usually the problem you found is caused by obsolete library
> dependencies. Just restarting the build is enough for fixing the problem
> *if* you are building all LLVM targets.
> 
> cmake/modules/LLVMLibDeps.cmake is regenerated every time a build that
> includes all LLVM targets finishes building the libraries. However, the
> tools keep using the old library dependencies until the next build. You
> can see LLVMLibDeps.cmake as a modified file on `svn status'. The right
> thing to do in this case is:
> 
> 1. Delete all libraries from the build directory.
> 2. `make' again.
> 3. Check that LLVMLibDeps.cmake was really changed.
> 4. Commit it.
> 
> The first two steps are necessary just in case some library was renamed
> or removed. The script that generates the library dependencies work on
> existing library files on the $BUILD/lib directory, so any stale file
> there will be included on its output.

Yeah, I'm not using CMake but wanted to unblock people.  Thanks for the work and the explanation!

-eric