[llvm-commits] [PATCH] Fix broken test on windows.

Michael Spencer bigcheesegs at gmail.com
Wed Aug 25 00:48:18 PDT 2010


This patch fixes a test on windows.

I could not figure out what the problem with the grep line was. I
could make it work by simply saving the file with VS, but that doesn't
make any sense because I checkout unix line endings and VS will use
unix line endings if that's what the file has. There are other tests
that use this exact same pattern (including the trailing \ and new
line with grep) that pass on windows.

The FileCheck lines are much clearer anyway (damn TCL). It also
doesn't include the embedded tab.

I'm posting this for review mainly because I'm not 100% sure the check
line is correct. I don't get why the %'s were in []'s in the grep
line. Was that just to make TCL happy?

- Michael Spencer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-windows-test.patch
Type: application/octet-stream
Size: 612 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100825/6da1c65c/attachment.obj>


More information about the llvm-commits mailing list