[llvm-commits] bug fix proposal

[Chris Lattner]

On Aug 24, 2010, at 7:28 AM, Hans Vandierendonck wrote:

> Hi,
> 
> The attached patch fixes a bug in lib/VMCore/Instructions.cpp, createMalloc() routine, where a BitCastInst is not inserted in any BasicBlock.

This is not correct, because of an incredibly poor design of CreateMalloc: it looks like the "InsertAtEnd" version does not insert the final instruction into the specified block!  This is terrible, but you'd need to fix the callers before this patch will work.

-Chris