[llvm-commits] [PATCH 0/5] ELF object support

[Daniel Dunbar]

On Fri, Aug 13, 2010 at 11:29 AM, Matt Fleming <matt at console-pimps.org> wrote:
> On Thu, Aug 12, 2010 at 10:44:05AM -0700, Daniel Dunbar wrote:
>> Hi Matt,
>>
>> I scanned the patches, they look reasonable to me. I have more review
>> comments, but I am eager to see this stuff land and I know others are
>> as well. I would rather get it in, and work from there.
>
> I was hoping this would be the case ;-) The idea was to get this stuff
> in as the first hurdle is the biggest. Incremental fix ups on top of
> that should be easier.
>
>> Assuming this stuff works, and passes some basic sanity checks, can
>> you go ahead and commit it?
>
> Sure thing. It passes some basic tests I have and....
>
>> It would be nice to get some tests for it -- have you thought at all
>> about writing a simple ELF object file dumping tool like we have for
>> Mach-O and COFF?
>
> ... I was planning on committing some ELF tests after the basic support
> went in just because I haven't written them yet. I hadn't thought about
> writing a dumping tool for ELF but I can certainly do that.
>
> Should I commit this series then?

Yes, please!

 - Daniel

>