[llvm-commits] [patch] pr7852 - Make LLVM robust to #define ARCH pollution by removing fragile macros.
Eric Christopher
echristo at apple.com
Tue Aug 10 10:54:01 PDT 2010
On Aug 10, 2010, at 3:45 AM, Xerxes RĂ„nby wrote:
> patch: http://llvm.org/bugs/attachment.cgi?id=5357
>
> Remove use of fragile macros to define native target init function names in
> include/llvm/Target/TargetSelect.h and llvm/include/llvm-c/Target.h
As I mentioned in the bug I don't think this is a problem on our end, but that
ffi is being really unfriendly. I have brought it up with those guys and they're
talking about it on the ffi-discuss list. This could happen with anyone defining
any arbitrary string - it's not outrageous that I would want to use FOOX86 or
FOOARM as a define for my project. It's even more understandable when
it's LLVM_FOOX86 and LLVM_FOOARM.
Let's hold off for a few days and see which way the ffi discussion is going
to go for now.
-eric
More information about the llvm-commits
mailing list