[llvm-commits] [llvm] r110683 - /llvm/trunk/lib/MC/MachObjectWriter.cpp

Michael J. Spencer bigcheesegs at gmail.com
Tue Aug 10 09:00:50 PDT 2010


Author: mspencer
Date: Tue Aug 10 11:00:49 2010
New Revision: 110683

URL: http://llvm.org/viewvc/llvm-project?rev=110683&view=rev
Log:
Revert "MC/MachO: Fix possible null pointer dereference."

This reverts commit 110575.

Target.isAbsolute() is true if SD would be null.

Modified:
    llvm/trunk/lib/MC/MachObjectWriter.cpp

Modified: llvm/trunk/lib/MC/MachObjectWriter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MachObjectWriter.cpp?rev=110683&r1=110682&r2=110683&view=diff
==============================================================================
--- llvm/trunk/lib/MC/MachObjectWriter.cpp (original)
+++ llvm/trunk/lib/MC/MachObjectWriter.cpp Tue Aug 10 11:00:49 2010
@@ -835,7 +835,7 @@
       // FIXME: Currently, these are never generated (see code below). I cannot
       // find a case where they are actually emitted.
       Type = RIT_Vanilla;
-    } else if (SD) {
+    } else {
       // Check whether we need an external or internal relocation.
       if (doesSymbolRequireExternRelocation(SD)) {
         IsExtern = 1;





More information about the llvm-commits mailing list