[llvm-commits] [llvm] r110590 - in /llvm/trunk/lib/CodeGen/AsmPrinter: DwarfDebug.cpp DwarfDebug.h

[Chris Lattner]

On Aug 9, 2010, at 3:23 PM, Bill Wendling wrote:

> On Aug 9, 2010, at 1:20 PM, Devang Patel wrote:
> 
>> Author: dpatel
>> Date: Mon Aug  9 15:20:05 2010
>> New Revision: 110590
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=110590&view=rev
>> Log:
>> It is ok, and convenient, to pass descriptors by value.
> 
> Why not by reference?

Because passing by value is more efficient for these simple value types.

Devang, the patch looks good to me, but please remove the const from things like this:

+void DwarfDebug::addSourceLine(DIE *Die, const DIVariable V) {

You seem to have made a large mechanical change, please tidy up.

-Chris