[llvm-commits] [Patch Proposal] fix unittests on mingw

[Zhanyong Wan (λx.x x)]

On Mon, Aug 9, 2010 at 1:52 PM, Nick Lewycky <nlewycky at google.com> wrote:
> Zhanyong, could you review these patches?
>
> On 9 August 2010 10:23, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
>>
>> Good midnight, everyone.
>>
>>
>> Their patches make "make unittests" fine on mingw.
>>
>>
>> * r110166-unittests-RDYNAMIC.diff.txt
>> On cygwin/mingw, this redefines $RDYNAMIC and suppress $RPATH.
>> TODO: it should be detected by autoconf.
>>
>> This enables exporting symbols from Executable.EXE.
>> (eg. unittests/JIT)

This one is about autotools.  Chandler is infinitely better than I am
as the reviewer.

>> * r106620-unittests-mingw-EXPECT_DEATH.diff.txt
>> gtest death test aborts with a desktop dialog on Windows 7.
>> I had to suppress death tests on mingw.

This change is actually about Haiku.  What am I missing?

>> r84355-unittests-workaround-msvcrt.diff.txt
>> This is workaround for PR6745 and PR7668.
>> http://llvm.org/bugs/show_bug.cgi?id=6745
>> (When the issue is resolved, we can meet failure by this patch.
>> Then we have to revert it.)

This looks good.

>>
>>
>> ...oyasuminasai...Takumi
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>
>



-- 
Zhanyong