[llvm-commits] [llvm] r110575 - /llvm/trunk/lib/MC/MachObjectWriter.cpp

Michael J. Spencer bigcheesegs at gmail.com
Mon Aug 9 08:28:05 PDT 2010


Author: mspencer
Date: Mon Aug  9 10:28:05 2010
New Revision: 110575

URL: http://llvm.org/viewvc/llvm-project?rev=110575&view=rev
Log:
MC/MachO: Fix possible null pointer dereference.

Discovered by Microsoft Visual Studio 2010 Code Analysis.

Modified:
    llvm/trunk/lib/MC/MachObjectWriter.cpp

Modified: llvm/trunk/lib/MC/MachObjectWriter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MachObjectWriter.cpp?rev=110575&r1=110574&r2=110575&view=diff
==============================================================================
--- llvm/trunk/lib/MC/MachObjectWriter.cpp (original)
+++ llvm/trunk/lib/MC/MachObjectWriter.cpp Mon Aug  9 10:28:05 2010
@@ -835,7 +835,7 @@
       // FIXME: Currently, these are never generated (see code below). I cannot
       // find a case where they are actually emitted.
       Type = RIT_Vanilla;
-    } else {
+    } else if (SD) {
       // Check whether we need an external or internal relocation.
       if (doesSymbolRequireExternRelocation(SD)) {
         IsExtern = 1;





More information about the llvm-commits mailing list