[llvm-commits] COFF patch

[Daniel Dunbar]

On Thu, Jul 29, 2010 at 4:56 PM, Cameron Esfahani <dirty at apple.com> wrote:
> My first patch, so please be gentle...
>
> This fixes a problem I was seeing with the COFF back end.  All of the string data was getting put into one data fragment, and so none of the fixup references were correct.

I'm not sure that this is the right fix. The fixups should be able to
deal with symbols being embedded inside a fragment via the Offset
field. In general, we don't want to create any more fragments than
necessary because they have a large impact on the assembly time. I
haven't looked at the COFF streamer or writer in detail, some I can't
speak to where the real bug is.

> I also made sure the TimeDateStamp in the COFF header had a correct value.

Ok, I assume this is fine but I don't know anything about COFF.

> I also fixed a spot in MCFragment where Offset wasn't being properly initialized.

I'm going to cherry pick this hunk.

 - Daniel

> This patch was generated against revision 109821.
>
>
>
>
>
> Cameron Esfahani
> dirty at apple.com
>
> "I cannot for the life of me understand why, while people without driver's licenses are not allowed on public roads, in bookstores one can find any number of books by persons without decency - let alone knowledge."
>
> "His Master's Voice", Stanislaw Lem
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>