[llvm-commits] [llvm] r109643 - in /llvm/trunk: include/llvm/Instructions.h lib/AsmParser/LLParser.cpp lib/Transforms/InstCombine/InstCombineCalls.cpp lib/VMCore/Instructions.cpp test/Assembler/align-inst-alloca.ll test/Assembler/align-inst-load.ll test/Assembler/align-inst-store.ll test/Assembler/align-inst.ll

Chris Lattner clattner at apple.com
Wed Jul 28 21:30:28 PDT 2010


On Jul 28, 2010, at 9:27 PM, Chris Lattner wrote:

>> 
>> +/// MaximumAlignment - This is the greatest alignment value supported by
>> +/// load, store, and alloca instructions.
>> +static const unsigned MaximumAlignment = 1u << 29;
> 
> How about making this an enum in the Instruction class (so it is llvm::Instruction::MaximumAlignment), instead of being llvm::MaximumAlignment?

Ok, same comment, but how about Value::MaximumAlignment now?

-Chris



More information about the llvm-commits mailing list