[llvm-commits] [patch] Fix bugpoint -inline ....

[Nick Lewycky]

+  for (unsigned i = 0, e = FunctionsBeingTested.size(); i !=e; ++i) {

Space after '!=' and before 'e' please.

+  for (unsigned i = 0, e = BBs.size(); i !=e; ++i) {

Here too!

Looks good!

On 25 July 2010 17:21, Rafael Espindola <espindola at google.com> wrote:

> > Do you want to use a SmallVector here?
>
> It is passed to a function and I wanted to avoid changing the
> interface. I implemented the other suggestions.
>
> The attached patch does a similar thing to the block reduction logic.
> With it bugpoint can run without crashing on the testcase I am trying
> to reduce.
>
> I did noticed another less serious problem with bugpoint that I might
> try to fix in another patch: When splitting the module into two parts,
> it will copy the functions it wants to optimize. When doing that it
> changes internal functions into regular ones and this sometimes masks
> the bug.
>
> For example, say a module has f1, f2 and f3. f2 is internal and the
> bug can be reproduced with only f1 and f2 but is masked if f2 is not
> internal. Bugpoint will fail to remove f3.
>

Generating testcases that are too large isn't my big worry with bugpoint.
I'm much more concerned about things like marking (or not marking) a
function fastcc as a result of it being inline.

Nick
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100728/a656f491/attachment.html>