[llvm-commits] [patch] Fix bugpoint -inline ....

[Nick Lewycky]

Looks good! Thanks for doing this.

+  // * If the optimization passes use inter procedural information to brake
+  //   a function, we want to contition with the original function.
Otherwise

"inter procedural" -> "interprocedural"
"brake" -> "break"
"contition" -> um, "continue" maybe?

+  std::vector<Function*> FuncsOnClone;

Do you want to use a SmallVector here?

+  for (unsigned i = 0, e = Funcs.size(); i !=e; ++i) {

Add space after "!=" before "e"

Nick

On 25 July 2010 07:13, Rafael Espindola <espindola at google.com> wrote:

> > it looks like you forgot to attach it...
>
> Arg.
>
> Attached now. I tested it on the testcase that caused it to crash. It
> is now able to correct split the functions into opt/non-opt and then
> crashes when handling the basic blocks.
>
> > Ciao,
> >
> > Duncan.
>
> Cheers,
> --
> Rafael Ávila de Espíndola
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100725/7f1d6e1f/attachment.html>