[llvm-commits] [llvm] r109262 - /llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp

[Daniel Dunbar]

On Fri, Jul 23, 2010 at 5:22 PM, Chris Lattner <clattner at apple.com> wrote:
>
> On Jul 23, 2010, at 3:40 PM, Devang Patel wrote:
>
>>>>
>>>>
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=109262&view=rev
>>>> Log:
>>>> IF directory name is empty then try to extract one using absolute file name.
>>>
>>> Hey Devang,
>>>
>>> Is this code commonly executed?  The sys::Path interfaces are very expensive.
>>
>> Once per compilation at max, but I introduced a bug here. I will fix it soon
>
> Ok! I'm not worried about the cost then, thanks.

I'm not worried about the cost, but I really don't think the backend
should be doing this. It introduces a behavioral dependency on the
current working directory inside codegen, which is a bad idea. 'llc
somepath/t.bc' should never behave differently from '(cd somepath &&
llc t.bc)'.

Also the commit doesn't have a test case, so it must not solve an
actual problem! :)

 - Daniel

> -Chris
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>