[llvm-commits] [llvm] r109288 - /llvm/trunk/include/llvm/Support/IRReader.h

[Owen Anderson]

Author: resistor
Date: Fri Jul 23 18:27:43 2010
New Revision: 109288

URL: http://llvm.org/viewvc/llvm-project?rev=109288&view=rev
Log:
Fix use-after-free error.

Modified:
    llvm/trunk/include/llvm/Support/IRReader.h

Modified: llvm/trunk/include/llvm/Support/IRReader.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/IRReader.h?rev=109288&r1=109287&r2=109288&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Support/IRReader.h (original)
+++ llvm/trunk/include/llvm/Support/IRReader.h Fri Jul 23 18:27:43 2010
@@ -79,10 +79,10 @@
                   (const unsigned char *)Buffer->getBufferEnd())) {
       std::string ErrMsg;
       Module *M = ParseBitcodeFile(Buffer, Context, &ErrMsg);
-      // ParseBitcodeFile does not take ownership of the Buffer.
-      delete Buffer;
       if (M == 0)
         Err = SMDiagnostic(Buffer->getBufferIdentifier(), ErrMsg);
+      // ParseBitcodeFile does not take ownership of the Buffer.
+      delete Buffer;
       return M;
     }