[llvm-commits] [llvm] r108609 - /llvm/trunk/lib/MC/MCParser/ELFAsmParser.cpp

[Chris Lattner]

On Jul 16, 2010, at 9:29 PM, Eli Friedman wrote:

> Author: efriedma
> Date: Fri Jul 16 23:29:04 2010
> New Revision: 108609
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=108609&view=rev
> Log:
> Work-in-progress parsing for ELF .section directive.

Cool.  If you're working on this, please keep in mind isValidSectionSpecifier in clang/lib/Basic/Targets.cpp.  The MachO implementation of this allows clang to diagnose invalid attribute(section)'s in sema, it would be nice for ELF to support a similar thing.  The Clang implementation for MachO looks like this:

  virtual std::string isValidSectionSpecifier(llvm::StringRef SR) const {
    // Let MCSectionMachO validate this.
    llvm::StringRef Segment, Section;
    unsigned TAA, StubSize;
    return llvm::MCSectionMachO::ParseSectionSpecifier(SR, Segment, Section,
                                                       TAA, StubSize);
  }

-Chris