[llvm-commits] [llvm] r107640 - in /llvm/trunk: include/llvm/Target/TargetLowering.h lib/CodeGen/StackProtector.cpp lib/Target/X86/X86ISelLowering.cpp lib/Target/X86/X86ISelLowering.h test/CodeGen/Generic/stack-protector.ll test/CodeGen/PowerPC/stack-protector.ll test/CodeGen/X86/stack-protector-linux.ll test/CodeGen/X86/stack-protector.ll

Nelson Elhage nelhage at nelhage.com
Tue Jul 6 14:59:33 PDT 2010


Oh, I see, you did put the X86 test in, you just dropped the one with
the wrong name. Looks like arm did get dropped somehow, though. Patch
attached to restore it.

- Nelson

-------------- next part --------------
A non-text attachment was scrubbed...
Name: stack-protector-arm.diff
Type: text/x-diff
Size: 1162 bytes
Desc: ARM -fstack-protector tests
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100706/417ead79/attachment.diff>
-------------- next part --------------

On Tue, 6 Jul 2010 14:38:44 -0700, Eric Christopher <echristo at apple.com> wrote:
> 
> On Jul 6, 2010, at 2:36 PM, Nelson Elhage wrote:
> 
> > I take it you dropped the X86 tests (in r107641) until you could get
> > around to FileCheck-izing them, but was it intentional that you
> > committed the PPC test case but not the arm one?
> 
> I thought I put them in?  Though I didn't see the arm one.  The new
> files didn't apply cleanly for some reason.  If you send me the files
> I'll commit them though.
> 
> -eric


More information about the llvm-commits mailing list