[llvm-commits] [llvm] r107667 - /llvm/trunk/include/llvm/Instructions.h

[Chris Lattner]

On Jul 6, 2010, at 8:44 AM, Gabor Greif wrote:

> Author: ggreif
> Date: Tue Jul  6 10:44:11 2010
> New Revision: 107667
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=107667&view=rev
> Log:
> second round of low-level interface squeeze-out:
> making all of CallInst's low-level operand accessors
> private
> 
> If you get compile errors I strongly urge you to
> update your code.

Hi Gabor,

I'm all for the spirit of this patch, however, this is really really gross:

> 
> +# define public private
> +# define protected private
>   /// Provide fast operand accessors
>   DECLARE_TRANSPARENT_OPERAND_ACCESSORS(Value);
> +# undef public
> +# undef protected

How about declaring a different macro, named DECLARE_PRIVATE_TRANSPARENT_OPERAND_ACCESSORS or something?

-Chris