[llvm-commits] [patch] Don't create neon moves in CopyRegToReg, instead trust NEONMoveFixPass to do the conversion
Rafael Espindola
espindola at google.com
Mon Jul 5 20:11:11 PDT 2010
On 5 July 2010 21:35, Evan Cheng <evan.cheng at apple.com> wrote:
> I have no problem with the patch. But I would feel a lot better if we are sure NEONMoveFix pass does not miss some important cases. I thought Jakob pointed out (in an earlier) thread that it's missing a case?
It was (and is) missing the ability to convert form NEON to VFP when
it is profitable to do so. What this patch does is avoid creating a
case where that ability is necessary.
I tested in a debugger that the pass is doing the right thing, it
finds that a register has been used with VFP and avoids converting a
move from it to NEON. I also did a make check, but I did no extra
testing to find if NEONMoveFix handles all the cases we might care
about.
> Evan
Cheers,
--
Rafael Ávila de Espíndola
More information about the llvm-commits
mailing list