[llvm-commits] [poolalloc] r107484 - /poolalloc/trunk/lib/DSA/DataStructureAA.cpp

Will Dietz wdietz2 at illinois.edu
Fri Jul 2 09:16:58 PDT 2010


Author: wdietz2
Date: Fri Jul  2 11:16:58 2010
New Revision: 107484

URL: http://llvm.org/viewvc/llvm-project?rev=107484&view=rev
Log:
temporarily remove the copy/deleteValue chaining

Modified:
    poolalloc/trunk/lib/DSA/DataStructureAA.cpp

Modified: poolalloc/trunk/lib/DSA/DataStructureAA.cpp
URL: http://llvm.org/viewvc/llvm-project/poolalloc/trunk/lib/DSA/DataStructureAA.cpp?rev=107484&r1=107483&r2=107484&view=diff
==============================================================================
--- poolalloc/trunk/lib/DSA/DataStructureAA.cpp (original)
+++ poolalloc/trunk/lib/DSA/DataStructureAA.cpp Fri Jul  2 11:16:58 2010
@@ -108,7 +108,11 @@
       InvalidateCache();
       BU->deleteValue(V);
       TD->deleteValue(V);
-      AliasAnalysis::deleteValue(V);
+      // FIXME: In the case that we chain to another ds-aa
+      // (and since we share the same TD/BU with that instance)
+      // we end up trying to delete the value twice.
+      // We *should* chain, but we also need to handle that case well.
+      //AliasAnalysis::deleteValue(V);
     }
 
     virtual void copyValue(Value *From, Value *To) {
@@ -117,7 +121,11 @@
       InvalidateCache();
       BU->copyValue(From, To);
       TD->copyValue(From, To);
-      AliasAnalysis::copyValue(From, To);
+      // FIXME: In the case that we chain to another ds-aa
+      // (and since we share the same TD/BU with that instance)
+      // we end up trying to copy the value twice.
+      // We *should* chain, but we also need to handle that case well.
+      //AliasAnalysis::copyValue(From, To);
     }
 
   private:





More information about the llvm-commits mailing list