[llvm-commits] [PATCH] Add some more ELF OSABI values.

Bill Wendling wendling at apple.com
Thu Jul 1 15:05:02 PDT 2010


On Jul 1, 2010, at 3:02 PM, Matt Fleming wrote:

> On Wed, 30 Jun 2010 15:41:03 -0700, Bill Wendling <wendling at apple.com> wrote:
>> Seems okay. Though why not change ELFOSABI_NONE to something that reflects what the comment says. Maybe ELFOSABI_SYSV or something?
>> 
>> -bw
> 
> I wanted to stick to the names defined in the System V ABI spec. The
> ELFOSABI values specify any ABI/OS extensions to the Sys V ABI, so the
> "NONE" part indicates that there is no extension to the vanilla Sys V
> ABI. If possible I'd like to use the names from the spec to makes things
> easier to lookup.

Okay.

-bw





More information about the llvm-commits mailing list