[llvm-commits] [poolalloc] r107165 - /poolalloc/trunk/lib/PoolAllocate/TransformFunctionBody.cpp

John Criswell criswell at uiuc.edu
Tue Jun 29 10:17:52 PDT 2010


Author: criswell
Date: Tue Jun 29 12:17:52 2010
New Revision: 107165

URL: http://llvm.org/viewvc/llvm-project?rev=107165&view=rev
Log:
Added comment on the use of StrictChecking when calling
DSGraph::computeNodeMapping().
Improved code formatting.

Modified:
    poolalloc/trunk/lib/PoolAllocate/TransformFunctionBody.cpp

Modified: poolalloc/trunk/lib/PoolAllocate/TransformFunctionBody.cpp
URL: http://llvm.org/viewvc/llvm-project/poolalloc/trunk/lib/PoolAllocate/TransformFunctionBody.cpp?rev=107165&r1=107164&r2=107165&view=diff
==============================================================================
--- poolalloc/trunk/lib/PoolAllocate/TransformFunctionBody.cpp (original)
+++ poolalloc/trunk/lib/PoolAllocate/TransformFunctionBody.cpp Tue Jun 29 12:17:52 2010
@@ -801,12 +801,18 @@
     NewCallee = CastInst::CreatePointerCast(CS.getCalledValue(), PFTy, "tmp", TheCall);
   }
 
+  //
+  // FIXME: Why do we disable strict checking when calling the
+  //        DSGraph::computeNodeMapping() method?
+  //
   Function::const_arg_iterator FAI = CF->arg_begin(), E = CF->arg_end();
-  CallSite::arg_iterator AI = CS.arg_begin() + (thread_creation_point ? 3 : 0), AE = CS.arg_end();
+  CallSite::arg_iterator AI = CS.arg_begin() + (thread_creation_point ? 3 : 0);
+  CallSite::arg_iterator AE = CS.arg_end();
   for ( ; FAI != E && AI != AE; ++FAI, ++AI)
-    if (!isa<Constant>(*AI))
+    if (!isa<Constant>(*AI)) {
       DSGraph::computeNodeMapping(CalleeGraph->getNodeForValue(FAI),
                                   getDSNodeHFor(*AI), NodeMapping, false);
+    }
 
   //assert(AI == AE && "Varargs calls not handled yet!");
 





More information about the llvm-commits mailing list