[llvm-commits] [llvm] r107142 - /llvm/trunk/lib/Transforms/IPO/StripSymbols.cpp

[Duncan Sands]

Author: baldrick
Date: Tue Jun 29 09:52:10 2010
New Revision: 107142

URL: http://llvm.org/viewvc/llvm-project?rev=107142&view=rev
Log:
Return Changed.  This required setting Changed if dbg metadata
is stripped off.  Currently set unconditionally, since the API
does not provide a way of working out if anything was actually
stripped off.

Modified:
    llvm/trunk/lib/Transforms/IPO/StripSymbols.cpp

Modified: llvm/trunk/lib/Transforms/IPO/StripSymbols.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/StripSymbols.cpp?rev=107142&r1=107141&r2=107142&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/IPO/StripSymbols.cpp (original)
+++ llvm/trunk/lib/Transforms/IPO/StripSymbols.cpp Tue Jun 29 09:52:10 2010
@@ -228,22 +228,24 @@
     Changed = true;
     NMD->eraseFromParent();
   }
-  
+
   NMD = M.getNamedMetadata("llvm.dbg.lv");
   if (NMD) {
     Changed = true;
     NMD->eraseFromParent();
   }
-  
+
   unsigned MDDbgKind = M.getMDKindID("dbg");
-  for (Module::iterator MI = M.begin(), ME = M.end(); MI != ME; ++MI) 
+  for (Module::iterator MI = M.begin(), ME = M.end(); MI != ME; ++MI)
     for (Function::iterator FI = MI->begin(), FE = MI->end(); FI != FE;
          ++FI)
       for (BasicBlock::iterator BI = FI->begin(), BE = FI->end(); BI != BE;
-           ++BI) 
+           ++BI) {
+        Changed = true; // FIXME: Only set if there was debug metadata.
         BI->setMetadata(MDDbgKind, 0);
+      }
 
-  return true;
+  return Changed;
 }
 
 bool StripSymbols::runOnModule(Module &M) {