[llvm-commits] [patch] Remove arm_aapcscc from some tests

Bob Wilson bob.wilson at apple.com
Wed Jun 16 15:07:41 PDT 2010


On Jun 16, 2010, at 7:27 AM, Rafael Espindola wrote:

>> I'm OK with it as long as the default ABI for non-Linux targets is APCS.  I took a quick look at it seems like that is true; AAPCS is only the default if the triple includes "eabi".  Otherwise, you're potentially changing the behavior of a lot of tests.  Even if those tests are not directly related to testing the ABI, there may be differences that affect what the tests do.
> 
> So, it looks like APCS is the default (I have no opinion if that is
> correct or not). Is this patch ok or should I update it to also pass a
> darwin triple to llc?

It's OK.  If I were you, I'd just leave these tests as they are, but I can't see any problem with changing them.



More information about the llvm-commits mailing list